[Associates Products Grid] Checkbox action on the row

OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.

https://www.openmage.org

Open Software License 3.0

869 stars 436 forks source link

[Associates Products Grid] Checkbox action on the row #4220

Open addison74 opened 1 month ago

addison74 commented 1 month ago

For a lot of grids in the Backend which have on the first column a checkbox we allowed to check/uncheck it only in that cell. In this way we avoided unchecking a product clicking by mistake on a row.

It seems we missed the Associated Products grid in a configurable product.

screenshot-2

sreichel commented 1 month ago

Seems grids behave different ...

E.g. in "Manage Products" clicking a row forwards to edit-page ...

Should it do nothing or go to product edit-page?

addison74 commented 1 month ago

Please check this behavior as follows

Related / Up-sells / Cross-sells grids in Product edit page
Category Products grid in Category tab

If you click on a row there is no action. For the checkboxes, Edit only clicking in the cells the action is performed.

As an answer to you question, it should do nothing.

sreichel commented 1 month ago

Maybe you want to fix it on your own ... its quite simple.

Add or change grids getRowUrl($row) to return empty string.

addison74 commented 1 month ago

For Related / Up-sells / Cross-sells grids this was the change https://github.com/OpenMage/magento-lts/pull/3865.