search

OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.
https://www.openmage.org
Open Software License 3.0
865 stars 436 forks source link

Create a composer meta package with magento mirrors #470

Closed Schrank closed 3 years ago

Schrank commented 6 years ago

https://twitter.com/Flyingmana/status/974253813409484801

Adding magento as a dependency for packages is hard, because we have a lot of magento mirrors, like:

So creating a composer meta package which expects one of the repos to be used might help here.

schmengler commented 6 years ago

Like this? https://magento.stackexchange.com/questions/84410/choose-which-file-to-install-via-composer-based-on-magento-version/84415#84415

There is no official magento/magento-ce package, so the users of your extension will probably install Magento from a community managed mirror like https://github.com/firegento/magento-ce or from their own repository. These must replace the "virtual" magento/magento-ce package of the same version (there is a placeholder self.version, so that you don't need to adjust the composer.json for each version update):

"replace": {
    "magento/magento-ce": "self.version"
}
Schrank commented 6 years ago

No a meta package which says "I am magento" and yo can fulfill me by installing either:

or some other package which we don't know. Is some work to collect them all, but then a dependency on magento is possible.

https://getcomposer.org/doc/04-schema.md#provide

Flyingmana commented 3 years ago

Closing this for now. A meta package could be created also from other organisations if still needed, we then could add support for this in OpenMage. But as OpenMage continuously moves forward and away from the original Magento1 version wise, this might become complicated to solve in a userfriendly way.