composer.json suggest Ikonoshirt_PBKDF2

kkrieger85 commented 5 years ago

In #307, some agreed to use better encryption and security.

Therefore we should add Ikonoshirt_PBKDF2 as suggestion to composer.json

fballiano commented 4 years ago

composer require "ikonoshirt/pbkdf2" can't find any packages, maybe it's not registered on packagist?

kkrieger85 commented 4 years ago

Should be found on github automagically: https://github.com/ikonoshirt/pbkdf2/blob/master/composer.json

kkrieger85 commented 4 years ago

I tried composer require ikonoshirt/pbkdf2 in a fresh OpenMage clone

here's the part from composer.lock

        {
            "name": "ikonoshirt/pbkdf2",
            "version": "v1.2.1",
            "source": {
                "type": "git",
                "url": "git@github.com:ikonoshirt/pbkdf2.git",
                "reference": "deca6fe3d09003e691dbd73b041618666e04f832"
            },
            "dist": {
                "type": "zip",
                "url": "https://api.github.com/repos/ikonoshirt/pbkdf2/zipball/deca6fe3d09003e691dbd73b041618666e04f832",
                "reference": "deca6fe3d09003e691dbd73b041618666e04f832",
                "shasum": ""
            },
            "suggest": {
                "magento-hackathon/magento-composer-installer": "*"
            },
            "type": "magento-module",
            "description": "Implements PBKDF2 as replacement for the standard magento password hashing",
            "time": "2020-04-04T16:11:32+00:00"
        },

colinmollenhour commented 4 years ago

I think with #998 the pbkdf2 module will be basically obsolete.

OpenMage / magento-lts

composer.json suggest Ikonoshirt_PBKDF2 #689