search

OpenMage / organizational

As some people feel the need to already know more about the future when M1 reaches EOL, here is an area for organizatorial stuff
3 stars 0 forks source link

Review and Merging rules #10

Closed Flyingmana closed 1 year ago

Flyingmana commented 6 years ago

I may mix this up with my other project, but was it always, that a single reviewer was enough for merging something?

I think it makes sense to have at least 2 reviewers (they dont even need to be maintainers)

sreichel commented 6 years ago

Agreed.

LeeSaferite commented 6 years ago

Well, you cannot force 2 approvals in GH, but the original idea was that you required 2 approvals to merge a PR.

Flyingmana commented 6 years ago

right, we can not enforce this via settings in Github, but we could at least write it down in a central place to refer to, in case someone forgets it, or gets new added to the team.