search

OpenMandrivaAssociation / distribution

OpenMandriva Lx is an exciting free Desktop Operating System that aims to cater to and interest first time and advanced users alike. It has the breadth and depth of an advanced system but is designed to be simple and straightforward in use.
https://openmandriva.org
7 stars 2 forks source link

KImageFormats HEIC support #2981

Closed Idesmi closed 2 weeks ago

Idesmi commented 3 weeks ago

When installing codecs from om-welcome > Applications > Multimedia > Codecs, qt-heif-image-plugin is pulled.

The problem is that qt-heif-image-plugin depends on KDE Frameworks 5. So it pulls a lot of dependencies that are not needed by KDE Plasma 6 and current KDE Apps.

KImageFormats, which in installed by default in OpenMandriva Rome 24.07 with Plasma 6, has support for HEIC images behind the build flag "KIMAGEFORMATS_HEIF".

I know that it's not build with support by default because of patents, but could be a separate build in the Restricted repo.

rugyada commented 3 weeks ago

The problem is that qt-heif-image-plugin depends on KDE Frameworks 5. So it pulls a lot of dependencies that are not needed by KDE Plasma 6 and current KDE Apps.

Fixed in om-welcome-2.7.6

Idesmi commented 3 weeks ago

Is there a reason why not to use KImageFormats?

AngryPenguinPL commented 3 weeks ago

I just prepared a kf6-kimageformats-heif version and it is in restricted repository. To download it you must first activate the restricted repository.

For now, change only applies to the Cooker release, if everything goes well it should also appear in ROME.

rugyada commented 3 weeks ago

Now also in ROME /testing repo.

Run command: $ sudo dnf --refresh --enablerepo=rolling-x86_64-restricted --enablerepo=rolling-testing-x86_64-restricted upgrade kf6-kimageformats

Idesmi commented 3 weeks ago

With heif support in KImageFormats, heifthumbnailer and qt-heic-image-plugin can be removed from this line: https://github.com/OpenMandrivaSoftware/om-welcome/blob/55a25d58d47b36e353eced64fc0a61b777669651/usr/share/om-welcome/apps/install-codecs.run#L9 and replaced with kf6-kimageformats-heif.

rugyada commented 2 weeks ago

I would have expected some feedback.

Idesmi commented 2 weeks ago

I would have expected some feedback.

I am new to OpenMandriva so I don't know how you do it here.

I tested the changes in a VM and everything is working fine.

I can also confirm that HEIF image preview in Dolphin is still shown even with the further modifications I proposed.