Open ghost opened 8 years ago
A new pull request had been done.
Hi Tioben,
Thanks for the pull request, I have your changes and I’m in the process of checking them out. I appreciate you taking the time to send in a update.
Thanks again,
Don
On Jan 27, 2016, at 9:48 AM, Tioben Neenot notifications@github.com wrote:
A new pull request had been done.
— Reply to this email directly or view it on GitHub https://github.com/OpenMap-java/openmap/issues/17#issuecomment-175664576.
Hi Don, OK about the update, but how can I do that ? I tried the last week and I've got some errors like "no sufficient rights" ! Le 1 févr. 2016 15:58, Don Dietrick notifications@github.com a écrit :Hi Tioben,
Thanks for the pull request, I have your changes and I’m in the process of checking them out. I appreciate you taking the time to send in a update.
Thanks again,
Don
On Jan 27, 2016, at 9:48 AM, Tioben Neenot notifications@github.com wrote:
A new pull request had been done.
— Reply to this email directly or view it on GitHub https://github.com/OpenMap-java/openmap/issues/17#issuecomment-175664576.
—Reply to this email directly or view it on GitHub.
I just downloaded the linked .zip file you attached to the pull request. There seemed to be a bunch of other changes in the pull request that were previous updates to OpenMap, I ignored those. In the future, you can specify which changes to include in the pull request and git will handle them for me (and you).
But that’s OK, I can work with almost anything, patch files, zipped changes, etc.
Thanks,
Don
On Feb 1, 2016, at 10:11 AM, Tioben Neenot notifications@github.com wrote:
Hi Don, OK about the update, but how can I do that ? I tried the last week and I've got some errors like "no sufficient rights" ! Le 1 févr. 2016 15:58, Don Dietrick notifications@github.com a écrit :Hi Tioben,
Thanks for the pull request, I have your changes and I’m in the process of checking them out. I appreciate you taking the time to send in a update.
Thanks again,
Don
On Jan 27, 2016, at 9:48 AM, Tioben Neenot notifications@github.com wrote:
A new pull request had been done.
— Reply to this email directly or view it on GitHub https://github.com/OpenMap-java/openmap/issues/17#issuecomment-175664576.
—Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub https://github.com/OpenMap-java/openmap/issues/17#issuecomment-178009326.
Hello Don and Tneenot, I just created a pull request containing only the patch from Tneenot which solves the problem. I think it will be easier to include :)
Sometimes, in GEN files linked with USR/ASRP files, the data size is not defined. Furthermore, the last field into the header (TXT=) can be absent. The results are some exception due to a size of 0 and due the absence of the TXT filed.