OpenMath / py-openmath

An OpenMath 2.0 implementation in Python
MIT License
15 stars 4 forks source link

Consider dropping support for older versions of Python #35

Open tkw1536 opened 4 years ago

tkw1536 commented 4 years ago

When making a PR I noticed that tests for older python versions are broken. In particular in Python2 the following test fails:

File "/home/travis/build/OpenMath/py-openmath/openmath/convert_pickle.py", line 14, in openmath.convert_pickle
Failed example:
    to_openmath('coucou')
Expected:
    OMString(string='coucou', id=None)
Got:
    OMBytes(bytes='coucou', id=None)

(see https://travis-ci.org/github/OpenMath/py-openmath/jobs/689618027#L207

Furthermore the Python 3.3 and Python 3.4 tests are failing because the python binaries can not be installed on Travis anymore.

We should consider if we want to keep supporting or testing these old versions of Python, in particular as all of them have reached end of life.

slel commented 3 years ago

NumPy has a "time window-based" policy for Python version support, described in NumPy Enhancement proposal 29:

SageMath is proposing to adopt it too: