search

OpenMediaVault-Plugin-Developers / installScript

script that installs omv-extras and openmediavault if not installed already.
1.07k stars 206 forks source link

Use gpg instead of apt-key add #119

Closed martinlarosa closed 7 months ago

martinlarosa commented 1 year ago

Should the install script use gpg instead of the deprecated apt-key add?

ryecoaaron commented 1 year ago

I plan on making that change once saltstack supports it. Since it is only deprecated in Debian 11, the change isn't required like it probably will be in Debian 12 (OMV 7.x).

ryecoaaron commented 1 year ago

https://github.com/OpenMediaVault-Plugin-Developers/openmediavault-omvextrasorg/blob/master/srv/salt/omv/deploy/omvextras/10omvextras.sls#L43

martinlarosa commented 1 year ago

I understand, I was just going through all my installation processes checking for this things since I'm trying to make everything as secure as possible now despite it not being mandatory from the OS perspective yet.

Would you mind helping me understand what that line you shared in your last comment is about? Do we need to change that or is that line dependent on a change from the saltstack project?

ryecoaaron commented 1 year ago

The line is just showing you that I plan to stop using apt-key as soon as saltstack supports it. There isn't much I can do until then unless I don't use saltstack which I don't want to.

martinlarosa commented 1 year ago

Thank you for the explanation, I appreciate it.

ryecoaaron commented 7 months ago

apt-key is no longer used when installing omv 7.