search

OpenMediaVault-Plugin-Developers / installScript

script that installs omv-extras and openmediavault if not installed already.
1.07k stars 206 forks source link

There is no need to execute wget or curl as root #42

Closed wstein closed 3 years ago

ryecoaaron commented 3 years ago

I disagree. Some people do not execute a sudo command before these commands. When wget is outputting to stdout, people will never get the sudo prompt to execute the downloaded content. And wgetting as root is not harmful.

wstein commented 3 years ago

I understand your purpose to add sudo to wget/curl. But is this assumption correct? In my opinion sudo never reads the password from stdin, but always prompt for it. Except you call it with the --stdio/-S option. At least all sudo implementation I am aware of work this way.

ryecoaaron commented 3 years ago

Try it.

What is the harm in wgetting as root?

wstein commented 3 years ago

It is useless and it is not necessary. That is all.

ryecoaaron commented 3 years ago

Having to support noobs on why they aren’t prompted for their password tells me otherwise and I have had to tell people a lot. I don’t understand why this is a big deal. Since there is nothing dangerous in using it and it makes my life easier, I am closing this issue.