search

OpenMediaVault-Plugin-Developers / installScript

script that installs omv-extras and openmediavault if not installed already.
1.07k stars 206 forks source link

Check for Display Manager #65

Closed yxtay closed 2 years ago

yxtay commented 2 years ago

Hmm, seems like there are folks facing installation issues with the latest commit. Is there a reason the check for display manager is necessary? OMV doesn't seem to have any issue being installed on desktop environment.

Error displayed: This system is running desktop environment! This is not supported. Exiting...

https://www.reddit.com/r/OpenMediaVault/comments/r7yenn/problem_installing_omv_on_debian_this_system_is/

ryecoaaron commented 2 years ago

Having a desktop environment installed causes many issues and there many threads about this on the forum. Networking and automounting of drives are two huge issues that cause a lot of grief. Is there a reason why you need a desktop environment for a machine that should be headless?

yxtay commented 2 years ago

I haven't experienced any of the problem you mentioned. I'm installing on Raspbian Bullseye, but will take note to install on the Lite version of the OS in the future.

Perhaps, it might be a good idea to include this information in the readme or FAQ somewhere, so users are able to understand why desktop environments are not unsupported and what they should do about it.

Or perhaps have the error displayed as a warning instead and allow users to continue the installation but clearly stating that there may be issues?

ryecoaaron commented 2 years ago

I haven't experienced any of the problem you mentioned.

I have seen this MANY times in my years of supporting OMV. You still don't mention why you need it?

Perhaps, it might be a good idea to include this information in the readme or FAQ somewhere, so users are able to understand why desktop environments are not unsupported and what they should do about it.

If people read the install guides, they wouldn't be using the desktop edition. Why would they read the readme or a FAQ if they evidently are not reading the install guide? I will add a note.

Or perhaps have the error displayed as a warning instead and allow users to continue the installation but clearly stating that there may be issues?

People will just ignore it and install it anyway.

yxtay commented 2 years ago

Thank you for the prompt reply.

I have seen this MANY times in my years of supporting OMV. You still don't mention why you need it?

I don't need the desktop environment. The context is that I have used a version of PiOS with desktop installed and would like to also use the OMV install script without having to reinstall the OS on my RPi again. As noted, I will use the lite version of the OS to avoid this problem in the future. It will not be a problem for me going forward, but perhaps not the same case for other less proficient users.

If people read the install guides, they wouldn't be using the desktop edition. Why would they read the readme or a FAQ if they evidently are not reading the install guide? I will add a note.

I don't see using non-desktop OS being recommended or required anywhere in the official guides. Perhaps this information can be provided there instead.

https://openmediavault.readthedocs.io/en/latest/installation/on_debian.html https://openmediavault.readthedocs.io/en/latest/installation/index.html https://openmediavault.readthedocs.io/en/latest/prerequisites.html

EDIT: I see it mentioned in the FAQ, but it is a recommendation, not a requirement: https://openmediavault.readthedocs.io/en/latest/faq.html

Can I install openmediavault on top a running Debian system? Yes, but it is recommended that the current running OS not to have a desktop environment installed.

People will just ignore it and install it anyway.

I understand that. Ignore that suggestion then.

ryecoaaron commented 2 years ago

I don't see using non-desktop OS being recommended or required anywhere in the official guides.

In your first link, it clearly says:

"Please do not install a graphical environment, use a minimal server installation only."

I see it mentioned in the FAQ, but it is a recommendation, not a requirement: https://openmediavault.readthedocs.io/en/latest/faq.html

If the official docs recommend against it, why would you still do it?? I honestly don't read the docs. The install script will continue to go with what I tell people.

yxtay commented 2 years ago

That settles it then. Thanks for your replies.

toxicfeet commented 2 years ago

I had same issue and i deleted these lines in install script file.

if dpkg -l | grep -Eqw "gdm3|sddm|lxdm|xdm|lightdm|slim|wdm"; then echo "This system is running a desktop environment!" echo "This is not supported. Exiting..." exit 101 fi

ryecoaaron commented 2 years ago

Deleting those lines defeats the purpose on why I added them.

sunhort commented 2 years ago

Makes no sense, I'm using OMV for 3 years now with mate, and never had any errors related to this. Now errors and regress from developer, thanks... Really have to copy and modify script..

ryecoaaron commented 2 years ago

Changing the install does not matter anymore since it is built into the openmediavault package now - https://github.com/openmediavault/openmediavault/blob/master/deb/openmediavault/debian/control#L11. And just because you haven’t had any problems yet, doesn’t mean it works fine. I have had many, many cases of this causing problems over the years.

sunhort commented 2 years ago

If any issues, will run OMV in docker than), but really on my multiserver I need DE to run genymotion for TV, I bet there is a lot of people who also need it. Sorry for being rude in my previous post. I respect developers labor but just like everyone else want things to get better. Versioning packages in linux always been a pain even for Linus Torvalds.

ryecoaaron commented 2 years ago

OMV does not work in docker. You could run omv in a VM on that system though. Being able to run OMV on a desktop environment is not better. They do too many things that conflict. An RPi is cheap enough that you could separate OMV from the desktop as well.

draven1322 commented 2 years ago

I too have ran OMV with a DE because I did not want a headless install. Use the system for other minor tasks which are much easier completed with a DE (like typing this post). I have run into issue with the DE and OMV installed before when a hard drive failed, but was easily fixed by editing the fstab then going into OMV and making drive changes. As long as you don't try to do anything with your shared drives in your DE you typically won't have problems (unless a drive fails, in which case, you just go into emergency mode and put a # in front of it in fstab).

I am now installing a second nas and also had to remove the lines from your script. Sorry.

That being said, I do understand why they were put there and if you don't understand most of what I just said, you probably should not remove them.

sunhort commented 2 years ago

Right, if everything works, why cut features? I also confirm things with drives, but DE setup still works

ryecoaaron commented 2 years ago

This is not an install script issue anymore. The openmediavault package itself has the restriction. The install script just stops to protect your desktop environment. If I removed that, installing the openmediavault package would uninstall your desktop.