OpenMediaVault-Plugin-Developers / installScript

script that installs omv-extras and openmediavault if not installed already.
1.07k stars 206 forks source link

Unclear why desktop environment isn't allowed #92

Closed tslmy closed 2 years ago

tslmy commented 2 years ago

I manually removed the check. The installation script turned out fine.

Can we remove that check?

ryecoaaron commented 2 years ago

Nope. It has been explained over and over and over why you shouldn't have a desktop installed with OMV due to the issues it causes. Search the forum. I still have yet to hear a good reason for a desktop to be installed.

You must have installed on Debian 10 Buster and got OMV 5.x. With OMV 6.x, it is in the openmediavault package itself - https://github.com/openmediavault/openmediavault/blob/master/deb/openmediavault/debian/control#L11. And if I allowed it for OMV 5.x, then people will just have the problem removing it when they upgrade to 6.x.

tslmy commented 2 years ago

Thanks for the explanation.

It has been explained over and over and over

Sorry to hear that. I'm even more sorry to say that I can foresee more questions like this.

May I suggest you add a link or two to the README file to frequently asked questions? Might save your time in the long run.

ryecoaaron commented 2 years ago

https://forum.openmediavault.org/

ryecoaaron commented 2 years ago

May I suggest you add a link or two to the README file to frequently asked questions? Might save your time in the long run.

I wrote this post a long time ago and no one reads it even when they go to the forum. It would prevent a lot of threads if people did read it.

ryecoaaron commented 2 years ago

https://github.com/OpenMediaVault-Plugin-Developers/installScript/commit/5930811973d71dcb88e7a5650201634c963b493a

And the readme already had a link to the forum.