search

OpenMediaVault-Plugin-Developers / installScript

script that installs omv-extras and openmediavault if not installed already.
1.1k stars 207 forks source link

Add a warning to README.md for people with pre configured wifi #96

Closed mareek closed 2 years ago

mareek commented 2 years ago

The goal of this merge request is to prevent people with WiFi pre configured to lose hours when trying to understand what's going on (see issues #7, #16, #60 or my own experience).

ryecoaaron commented 2 years ago

Your note is not true though. If you setup wifi the way the RPi Foundation recommends (using wpa_supplicant.conf), you won't lose your setup. If you choose to setup wifi in a different manner, the script cannot support every type of setup.

mareek commented 2 years ago

I've setup the wifi using the official raspberry pi imager so it's not an exotic or unrecommended way of configuring the wifi. My note might be wrong but, seeing the issues on this repo and the messages in the forums, I think adding a warning would be helpful to a lot of people.

ryecoaaron commented 2 years ago

Some of the issues on this repo and on the forum were created before the install script had support for wifi. A lot of time has been spent on the install guide with the primary focus of RPi users and it has all of these warnings. I will add a message but most people will not read anything and run into the problem anyway.

I haven't tried the raspberry pi imager to see how it configures wifi. I will check it out.

ryecoaaron commented 2 years ago

message added.

ryecoaaron commented 2 years ago

So, RPi imager puts an encrypted password in /etc/wpa_supplicant/wpa_supplicant.conf. This means it is not in quotes and the script would not find it. BUT even if it could and put it in the OMV database, OMV's code puts the password in quotes when it writes the netplan config file meaning it would interpret the hash as the password. The install script would have to be able to decrypt the password to work.