OpenMediaVault-Plugin-Developers / openmediavault-compose

openmediavault plugin for docker-compose
14 stars 5 forks source link

Changes to /etc/docker/daemon.json are lost #10

Closed subjut closed 1 year ago

subjut commented 1 year ago

I have installed docker (through omv plugins) onto a zfs volume and need to run docker with the zfs driver enabled. To use it I have to add the option "storage-driver": "zfs" to /etc/docker/daemon.json (docker documentation). I can do it manually, restart docker over ssh and it works, but I noticed that the option is lost at some point. When I then restart the server, docker starts with the overlay2 driver and most of my containers fail to start because of permission problems.

Is it possible to add additional options to daemon.json? If not, could we have a field, where we can add additional options, or a checkbox to indicate, that the file should not be touched by the plugin?

Thanks.

ryecoaaron commented 1 year ago

If you leave the Docker storage field on the Settings tab blank, it will not do anything with the daemon.json file.

subjut commented 1 year ago

Ah, good to know. Thanks.

Maybe this could be mentioned on the settings page.

ryecoaaron commented 1 year ago

Just added it. https://github.com/OpenMediaVault-Plugin-Developers/openmediavault-compose/commit/099a103fa6849dbbd2db0750b00a07764e302313