search

OpenMediaVault-Plugin-Developers / openmediavault-cups

CUPS plugin for OpenMediaVault
7 stars 8 forks source link

Reverse order in job list #6

Closed eckhbeck closed 10 years ago

eckhbeck commented 10 years ago

IMHO it is more practical to show the newest jobs in the job list rather than vice versa. The latest jobs are normally the ones one is interested in the most. My (completed) job list grew to several pages now and it is a bit of a hassle to move to the last page first to check the latest printed job(s). I know that clicking the table header will reverse order of the page but that is only relevant to the current page and not the complete job list.

I did a quick hack to the Python script /usr/local/bin/omvcups.py for this so maybe this can be just taken over:

80c80
<               for j in self.conn.getJobs(which,False, -1, -1).keys():

---
>               for j in reversed(self.conn.getJobs(which,False, -1, -1).keys()):
ghost commented 10 years ago

I'm pretty sure that's what it did before the port to 0.5 but I may have missed something. I'll look into it. Should it be sorted by the created or the completed date?

eckhbeck commented 10 years ago

Ok, thanks!

I'd say the 'completed' date but honestly I didn't check that. I just made the change mentioned in my initial request to reverse what's returned by the getJobs call. I just saw that my diff output was rendered very ugly. How does one input code in the issues???

eckhbeck commented 10 years ago

the change does not exactly solve the issue. Now, the table is sorted top down BUT it's sorted per page. Currently I do have ~100 (completed) jobs and the 25 oldest are on page 1. IMHO one is normally interested in the latest jobs so page 1 should show jobs 100-76, ... That's why I suggested to change the order of the list 'printed' by omvcups.py as mentioned in my initial message.

And it looks like since I upgraded to OMV 0.6 that omvcups.py does not return all info correctly so column 'Name' is empty now and column User shows '@' for each and every job.

ghost commented 10 years ago

I forgot to set remoteSort to true and didn't notice since I only had four jobs in my list. :)

The name and user issue should be fixed too and was caused by some changes in Cups.

eckhbeck commented 10 years ago

Awesome! The table looks as expected now ;-) Thanks a lot!

Btw, I copied the changed files manually to their respective location. You should update 'debian/changelog' so a new package will be generated, shouldn't you?

ghost commented 10 years ago

I just had to check which version was in the repo. I just bumped the version :)