Docker modify 3.0 does not retain port forward

[subzero79]

In the the latest build from source, modify button works as expected on some parameters but fails on port forward.

When we click the modify button all port fordward are not displayed as in the currently running container. The problem comes even after manually adding the port forward to the modify dialog, the port is still not forwarded.

[nicjo814]

I'm trying to reproduce this but I fail... Could you provide exact steps performed and image used?

[subzero79]

I think the latest commits fix it in way that now shows the port forward ready as a configuration (like the plus button already pressed for the port), but when you press run the port is not forwarded.

I use this personal image

https://gist.githubusercontent.com/subzero79/aa878afd2eee601acb63/raw/b0ab45feb4e0260565715a8814a145f255a920c8/squid

[subzero79]

Can't seem to reproduce the issue right now, i was gonna make a screen video. Let you know through the day so we can possibly close this

[nicjo814]

Can I close this issue?

[subzero79]

I thought it was single problem, today i experienced this again with another image/container

Look at this screen video

https://dl.dropboxusercontent.com/u/54639/docker.mp4

[nicjo814]

Hmmm... Looking at your video I notice that when you open the modify dialogue the first time it says networking mode "Default" and I can't see any IP (0.0.0.0) in the configuration for port 8112. Both things are a bit suspicious :-) I'll try to dig into this some more. Do you know how you configured the container initially?

[subzero79]

Aha, understand i started the container in CLI, like

docker run -d --volumes-from=deluge-data -p 8112:8112 --name=deluge xataz/deluge:1.3-stable

So you pass the explicit option --net=bridge always, that must be the issue. As i selected bridge and it works properly. So is my bad usage

Guess we can close now.

Note: watch the video at the end the modify calls the exposed volumes to modify only in the host path, in this case i am calling the volumes from another container, so i am not ount binding.

[nicjo814]

Good catches both of them! I need to handle containers started from cli as long as the parameters provided are supported by the plugin (both network mode and volumes-from in this case). I'll fire up the same image here and take a look at the json data from "docker inspect" to see if I can correct this. I'll leave this issue open and close it when both problems are fixed.

[nicjo814]

The issue with the "default" networking mode should be fixed now. Regarding "volumes-from" I think it's working properly. In your video you would see the correct volume being listed below the "standard" bind-mount/volumes fields in it's own area called "volumes from".

[nicjo814]

I'll close this issue and publish version 3.0.7 on Bintray.