search

OpenMediaVault-Plugin-Developers / openmediavault-docker-gui

Docker plugin for OpenMediaVault
32 stars 17 forks source link

Adding module for Services indication #47

Closed 1activegeek closed 7 years ago

1activegeek commented 7 years ago

First attempt at contributing code! Hopefully this looks good. Copied from what other were doing, and had to iron out that this plugin has the config property listed as "enabled" vs "enable" which most others are using.

subzero79 commented 7 years ago

Looks good to me. I tested and works as expected

1activegeek commented 7 years ago

Sweet! Glad to be contributing for once. I was concerned as I read the HOWTO on plugin development which outlined a different method it seems to likely get the same information. In the end, I worked with a copy from one of the plugins instead of trying to decipher the howto guided method. Glad it worked!

subzero79 commented 7 years ago

@nicjo814 any comments? is the listener necessary ?

nicjo814 commented 7 years ago

The code looks good to me. I don't know about the listener though, haven't worked with those before. I thought it was used to detect changes to settings etc and then fire some script after you hit "apply".