search

OpenMediaVault-Plugin-Developers / openmediavault-docker-gui

Docker plugin for OpenMediaVault
32 stars 17 forks source link

Added container command parameter #55

Closed Matty666 closed 6 years ago

Matty666 commented 6 years ago

This enables passing commands to containers when they are started. This implements issue #53

nicjo814 commented 6 years ago

This looks like are very nice addition to the plug-in. I'll give it a try later today to see how it works. Thanks for the contribution!

Matty666 commented 6 years ago

@subzero79 I can change those columns to be hidden by default, no problem, is there an example of the properties I need to set somewhere?

subzero79 commented 6 years ago

From memory now, the filesystem grid in core Omv has some hidden columns

just double check:

hidden: true

subzero79 commented 6 years ago

Gonna merge this. The release of 4.x is very close. I have to make a new PR for the new changes.

Matty666 commented 6 years ago

Ok no problem. I checked and you're right, just haven't had time to change and test it. I'll submit a new pr with the change.

Matt

From: subzero79 notifications@github.com Sent: Wednesday, February 7, 2018 7:44:49 PM To: OpenMediaVault-Plugin-Developers/openmediavault-docker-gui Cc: Matt Evans; Author Subject: Re: [OpenMediaVault-Plugin-Developers/openmediavault-docker-gui] Added container command parameter (#55)

Gonna merge this. The release of 4.x is very close. I have to make a new PR for the new changes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/OpenMediaVault-Plugin-Developers/openmediavault-docker-gui/pull/55#issuecomment-363697285, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAMWIAvnqXEL7XImwNr7iHgf6yDPtFHkks5tSWKAgaJpZM4RVgbE.

subzero79 commented 6 years ago

I mean i have to submit a big PR from my repository. Big changes, look at my github unixsocket branch