search

OpenMediaVault-Plugin-Developers / openmediavault-docker-gui

Docker plugin for OpenMediaVault
32 stars 17 forks source link

Logofix #56

Closed nicjo814 closed 6 years ago

nicjo814 commented 6 years ago

This should fix the issue when an image in the Repo tab uses a logo that isn't available. The solution is to simply skip such images.

ryecoaaron commented 6 years ago

The changelig stuff is fine. Just is white space removed from end of lines

subzero79 commented 6 years ago

How do we test this @nicjo814 ?

send to localhost the image URL in /etc/hosts?

nicjo814 commented 6 years ago

That sounds like a nice way. I tested it when there was an actual broken URL in the real json data...

subzero79 commented 6 years ago

I've tried this both URL in /etc/hosts

https://tools.linuxserver.io/docker-templates.json

http://openmediavault-plugin-developers.github.io/openmediavault-docker-repo/dockerlist_amd64.xml

And i cannot reproduce the error, so it must fail for single image