search

OpenMediaVault-Plugin-Developers / openmediavault-downloader

OpenMediaVault plugin for downloading files
11 stars 11 forks source link

Added support for ulozto-downloader #18

Closed filo891 closed 1 year ago

filo891 commented 1 year ago

This pull request implements support for another download engine (ulozto-downloader)

ryecoaaron commented 1 year ago

A few things...

You would lose all of the helpful out that it looks ulozto has. And since it is a parallel downloader, you wouldn't see filesize tracking in the plugin.

You added a "parts" field but it is never used.

I'm not of fan of plugins using pip to install primary services. Since pip will always install bleeding edge version, something may change breaking the plugin. And the pip package might require a dependency in common with OMV itself breaking OMV by downloading a version too new.

filo891 commented 1 year ago

Thanks for the inputs.

You would lose all of the helpful out that it looks ulozto has. And since it is a parallel downloader, you wouldn't see filesize tracking in the plugin.

Perhaps a feature for visualizing the log file could help here? I could look into that further. For now I was only looking for a simple implementation following the existing logic for the other downloaders.

You added a "parts" field but it is never used.

I guess I should stop doing late night coding marathons :) I seem to have forgot to add it.

I'm not of fan of plugins using pip to install primary services. Since pip will always install bleeding edge version, something may change breaking the plugin. And the pip package might require a dependency in common with OMV itself breaking OMV by downloading a version too new.

I see your point, it could be perhaps addressed by hardcoding the downloader version into to the plugin and only bump versions with new releases of the plugin so the dependencies are under control.

ryecoaaron commented 1 year ago

Perhaps a feature for visualizing the log file could help here? I could look into that further. For now I was only looking for a simple implementation following the existing logic for the other downloaders.

That's fine. Just wanted to point it out since ulozto looks to have good console output and people have complained about the info the downloader plugin gives.

I see your point, it could be perhaps addressed by hardcoding the downloader version into to the plugin and only bump versions with new releases of the plugin so the dependencies are under control.

That would be a good change.

filo891 commented 1 year ago

I have added the dependency versions in the installer and included the value of the "parts" field in the code.

Once https://github.com/setnicka/ulozto-downloader/pull/132 will be finished and merged, I'll look into improving the information shown in the GUI as it will be much easier to obtain the download progress information in a programmatic way.