search

OpenMediaVault-Plugin-Developers / openmediavault-fail2ban

11 stars 5 forks source link

Version for OMV3 bis #14

Closed prbond closed 8 years ago

ryecoaaron commented 8 years ago

Since there were conflicts in this request as well, I just merged your changes as a commit. Can you check to make sure they are correct? I also made a 1.x branch to hold the code for OMV 1.x and 2.x compatibility since we typically keep the current OMV version code in the master branch where I merged your changes.

prbond commented 8 years ago

Yes i think all are ok, but maybe create branch 2.X instead 1.X and rename master-omv to 3.X ?

ryecoaaron commented 8 years ago

I named it 1.x since the control file said it still worked with OMV 1.x. You can name the branches whatever you want. I was just suggesting what we do with the other plugins. You have permissions to create branches, right?

prbond commented 8 years ago

I begin with OMV 2.X. Yes i have permissions but i need your advice before making a stupidity.

ryecoaaron commented 8 years ago

I changed it to 2.x. I'm sure you won't do anything stupid :)