OpenMediaVault-Plugin-Developers / openmediavault-omvextrasorg

OpenMediaVault plugin for omv-extras.org repository
150 stars 53 forks source link

Fix cockpit dependency in buster-backports #48

Closed tjjh89017 closed 3 years ago

tjjh89017 commented 3 years ago

Fix QEMU dependency in buster-backports

QEMU update dependency in buster-backports libfdt need to be updated to buster-backports too Pin libfdt* to buster-backports affected: libfdt1, libfdt-dev

Fix install cockpit dependency

cockpit only depend on libvirt, but libvirt didn't depend on qemu-system-x86 or qemu-kvm

ryecoaaron commented 3 years ago

Can you change that to libfdt1 instead of libfdt*?

tjjh89017 commented 3 years ago

I want to capture both of "libfdt1" for binary and "libfdt-dev" for headers if you install libfdt1 with buster-backports version and libfdt-dev with buster. That will be confused for those need to compile something on their own.

i search "libfdt*" and only get 2 result (libfdt1 and libfdt-dev) or maybe i should use two entries to pin the version?

tjjh89017 commented 3 years ago

sorry, i hit the wrong button to close it.

ryecoaaron commented 3 years ago

Why would you need headers unless you are building the packages? 99.9% of omv users are not building anything. So, the omv-extras button does not need to account for those cases.

tjjh89017 commented 3 years ago

I would like to consider all situations. But if you think that is not necessary I'll change to libfdt1

ryecoaaron commented 3 years ago

If we considered all situations, we would end up going down a long road and installing build-essential, linux-headers, libvirt, etc. I prefer to keep it simple and exact. If someone wants the dev package from backports, they can do it from command line.

tjjh89017 commented 3 years ago

Ok got it I reword and fix the libfdt1 instead libfdt* Only pin libfdt1

ryecoaaron commented 3 years ago

thanks. I will push a new package in just a bit.

tjjh89017 commented 3 years ago

Thanks for help!

ryecoaaron commented 3 years ago

5.4.4 is in the repo now.

tjjh89017 commented 3 years ago

i installed it and check it's all fine. Thanks a lot