search

OpenMediaVault-Plugin-Developers / openmediavault-unionfilesystems

OpenMediaVault plugin for union filesystems
9 stars 6 forks source link

add MSP (most shared path) based policies to the web ui #41

Closed TomW1605 closed 2 years ago

TomW1605 commented 2 years ago

please add the new MSP (most shared path) policies to the web ui policies

ryecoaaron commented 2 years ago

I would prefer not to have to add features to this plugin since it has been consolidated into openmediavault-mergerfs with OMV 6.x and has those polices - https://github.com/OpenMediaVault-Plugin-Developers/openmediavault-mergerfs/blob/main/usr/share/openmediavault/workbench/component.d/omv-storage-mergerfs-form-page.yaml#L87

TomW1605 commented 2 years ago

thats fair but as i understand it OMV 6 is still in active development and not yet ready for full use (i may be wrong about this) and from tests i have done it only requires some changes to the config ui and datastore files (again i might be wrong about this). if this is the case i see no harm in adding it for those of us who do still use OMV 5

ryecoaaron commented 2 years ago

The release candidate for OMV 6 was released at the beginning November and there have been 14 updates since.

I agree there is no harm but you are the only one asking for it and it takes my time and two plugins need the update and there won't be any translations...

5.1.3 is in the repo.

TomW1605 commented 2 years ago

ok thanks.

i noticed that you only edited the ui file. from my tests you also need to edit the files in datamodels otherwise it will through an error if you pick the new policies. im happy to make a PR for this if you want

ryecoaaron commented 2 years ago

And now it takes even more of my time. I should've just said use the mergerfsfolders plugin since it already allowed the new policies. 5.1.4 in the repo.

TomW1605 commented 2 years ago

oh thanks for that. i didnt know about the mergerfsfolders plugin.

sorry for taking your time