search

OpenMendel / SnpArrays.jl

Compressed storage for SNP data
https://openmendel.github.io/SnpArrays.jl/latest
Other
44 stars 9 forks source link

replace macros in Gaius with Base.threads macros for SnpLinAlg #119

Closed biona001 closed 2 years ago

biona001 commented 2 years ago

This is for #118.

I'm still not sure why Gaius's macros fail to multithread sometimes, but when it fails, switching to macros based on Base.Threads always worked

codecov-commenter commented 2 years ago

Codecov Report

Merging #119 (1d1d96c) into master (db152fd) will increase coverage by 0.25%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   85.23%   85.48%   +0.25%     
==========================================
  Files          14       14              
  Lines        1564     1564              
==========================================
+ Hits         1333     1337       +4     
+ Misses        231      227       -4
Impacted Files Coverage Δ
src/linalg_direct.jl 84.76% <50.00%> (+0.98%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db152fd...1d1d96c. Read the comment docs.

kose-y commented 2 years ago

I used it because I thought using @sync and @spawn might slow things down on a single thread job. It doesn't seem like the case and Gaius.jl is no longer using the macro, so let's merge it.

kose-y commented 2 years ago

Thanks, Ben!