search

OpenMendel / SnpArrays.jl

Compressed storage for SNP data
https://openmendel.github.io/SnpArrays.jl/latest
Other
44 stars 9 forks source link

close vcf readers #80

Closed biona001 closed 3 years ago

biona001 commented 3 years ago

If readers aren't closed there might be bugs

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.04%) to 86.089% when pulling 4b4355201603ac752f8eea3423b641204bc7a2e3 on develop into d56df9d13a2c3848ae3b8c528dd421e2ed42ccf0 on master.

codecov-io commented 3 years ago

Codecov Report

Merging #80 into master will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   83.79%   83.83%   +0.04%     
==========================================
  Files          14       14              
  Lines        1197     1200       +3     
==========================================
+ Hits         1003     1006       +3     
  Misses        194      194
Impacted Files Coverage Δ
src/vcf2plink.jl 95.31% <100.00%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d56df9d...4b43552. Read the comment docs.

kose-y commented 3 years ago

Yeah, looks like my mistake.