OpenMendel / SnpArrays.jl

Compressed storage for SNP data
https://openmendel.github.io/SnpArrays.jl/latest
Other
44 stars 9 forks source link

Snp lin alg matrix mul #94

Closed biona001 closed 3 years ago

biona001 commented 3 years ago

This PR

If @kose-y thinks it's okay, and version 0.20.19 of VectorizationBase.jl is released, I think it's ready to merge

biona001 commented 3 years ago

I also just realized the latest VectorizationBase.jl release is still at v0.20.18 (although for some reason Chris Elrod released v0.18.15 a few hours ago.... not sure why).

Need to wait until v0.20.19 is released before merging this PR. To test the code, one need to use master branch VectorizationBase.jl

biona001 commented 3 years ago

VectoriztionBase.jl v0.20.19 has been released, so this pr is ready for review now.

kose-y commented 3 years ago

Thank you. It will be merged after re-running the CI tests.

codecov-commenter commented 3 years ago

Codecov Report

Merging #94 (1e54b67) into master (07b8d67) will decrease coverage by 1.36%. The diff coverage is 80.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   87.54%   86.18%   -1.37%     
==========================================
  Files          14       14              
  Lines        1285     1433     +148     
==========================================
+ Hits         1125     1235     +110     
- Misses        160      198      +38     
Impacted Files Coverage Δ
src/linalg_direct.jl 86.31% <80.82%> (-8.35%) :arrow_down:
src/vcf2plink.jl 95.16% <0.00%> (-0.23%) :arrow_down:
src/SnpArrays.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07b8d67...1e54b67. Read the comment docs.