GeometricDistribution and fixed LaplaceDistribution - Githubissues

OpenMined / PyDP

The Python Differential Privacy Library. Built on top of: https://github.com/google/differential-privacy

Apache License 2.0

507 stars 138 forks source link

GeometricDistribution and fixed LaplaceDistribution #205

Closed BenjaminDev closed 4 years ago

BenjaminDev commented 4 years ago

Description

Added GeometricDistribution and fixed LaplaceDistribution.
Added more tests (I'm still unsure how we should be testing these bindings current coverage is poor)
Added sphinx style docstrings to all functions I touched. These can be used to generate docs. PR for sphinx setup coming.
Updated the git submodule sha to match docker and setup scripts.

Affected Dependencies

None.

How has this been tested?

pytest on python 3.7 all tests pass.

Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[ ] I have labeled this PR with the relevant Type labels
[x] My changes are covered by tests

chinmayshah99 commented 4 years ago

Creating an issue for the test that fails #213