OpenMined / PyDP

The Python Differential Privacy Library. Built on top of: https://github.com/google/differential-privacy
Apache License 2.0
507 stars 138 forks source link

Run clang-format from the system installation instead of pipenv #216

Closed codeboy5 closed 4 years ago

codeboy5 commented 4 years ago

Description

This PR removes clang-format as a Pip dependency and updates the Makefile to run clang-format from the system clang-format installation. Fixes #215

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

Running make format-style-cpp does work.

Checklist

chinmayshah99 commented 4 years ago

Is installing clang-format part of prereqs_linux.sh and prereqs_mac.sh?

codeboy5 commented 4 years ago

Is installing clang-format part of prereqs_linux.sh and prereqs_mac.sh?

It was never a part of it, we could update it tho.

chinmayshah99 commented 4 years ago

Please do