Closed BenjaminDev closed 4 years ago
Update:
twine check dist/*
as we now reading in a .rst for long_description in the setup.py file.Notes:
To support windows I had to add configs to the .bazelrc
file and so when you build you'll need to add --config Linux
, --config macOS
or --config Windows
. I have not updated the make files nor scripts with this change. It's a easy fix if you run into it and a small change to fix. I just cannot test make
and .sh
files on this windows box.
So to build on linux bazel build --config Linux .......
Fixes #111 , #112
Description
Working on #112. This is new PR on the same issue as a number of the initial changes have been correctly moved upstream see google/differential-privacy#47 (still open) and google/differential-privacy#34 (closed)
Adding windows support for PyDP.
Notes
There are 4 files changed here but only 2 are needed when the upstream library merges PR google/differential-privacy#47
Required changes to python-dp to support windows:
_pydp.pyd
to setup.pypackage_data={"pydp": ["_pydp.so","_pydp.pyd"],},
so the windows package includes the built binary.Extra changes that are WIP for now and will be reomved when PR google/differential-privacy#47 is merged.
.gitsubmodules
to point to my personal fork of the google/differential-privacyWindows python-dp wheels
If you want to test the wheels or use for a demo feel free to look here for a windows wheel:
Affected Dependencies
Moved base library to a private fork. Don't merge yet WIP. See notes above.
How has this been tested?
pytest tests
against the built wheels for all python versions and they all passed seeChecklist
TODO