OpenMined / PyDP

The Python Differential Privacy Library. Built on top of: https://github.com/google/differential-privacy
Apache License 2.0
501 stars 139 forks source link

[WIP] Create script from Laplace Demo notebook for mypy testing #322

Closed NateSolon closed 3 years ago

NateSolon commented 3 years ago

Description

Mypy can't test .ipynb files. I converted the Laplace Demo notebook to a script via jupyter nbconvert --to script which can be tested with mypy, similar to how is done for the other notebook examples.

How has this been tested?

I wasn't able to run the tests locally so I'm going to see if it works when I submit the PR.

Checklist

chinmayshah99 commented 3 years ago

This seems to be passing and looks good. Though a good idea would be adding mypy tests over here: https://github.com/OpenMined/PyDP/blob/dev/tests/notebooks/test_all_notebooks.py

chinmayshah99 commented 3 years ago

357 fixes it