Moved pydp folder under src

OpenMined / PyDP

The Python Differential Privacy Library. Built on top of: https://github.com/google/differential-privacy

Apache License 2.0

506 stars 138 forks source link

Moved pydp folder under src #332

Closed siddhesh1598 closed 3 years ago

siddhesh1598 commented 3 years ago

Description

Moved the pydp folder under the src folder. Created a BUILD for the pydp folder and extended it with the bindings_test. Closes issue #291.

How has this been tested?

I tested it by running the docker image. I ran the following commands to reproduce the results. $ docker build -t pydp:test . $ docker run --rm -it pydp:test $ make test $ make build $ poetry run python examples/carrots_demo/carrots.py

Checklist

[Yes ] I have followed the Contribution Guidelines and Code of Conduct
[Yes ] I have commented my code following the OpenMined Styleguide
[Yes ] I have labeled this PR with the relevant Type labels
[Yes ] My changes are covered by tests

alejandrosame commented 3 years ago

@siddhesh1598 ping

@chinmayshah99 I already have a testing improvement waiting for this PR to be merged, I noticed the pydp binary there and deleted it.

chinmayshah99 commented 3 years ago

@alejandrosame Maintainers' edit isn't enabled on this PR. Let's wait till tonight, and then merge ( we can delete the bin file)

siddhesh1598 commented 3 years ago

@chinmayshah99 are you talking about the bazel bin files? Also, the maintainer's edit is allowed on this PR. Sorry, I was caught up with some tasks from work.

chinmayshah99 commented 3 years ago

@siddhesh1598 can you please delete the bazel bin file?

chinmayshah99 commented 3 years ago

We would have just one last release with py35 in the coming week(s), post which we won't be supporting py35.

Regards

Chinmay Shah

On Wed, Dec 16, 2020, 11:10 benjamin de charmoy notifications@github.com wrote:

@BenjaminDev approved this pull request.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenMined/PyDP/pull/332#pullrequestreview-553371127, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTTOFOZBV36RRM4XKKHAZLSVBB5LANCNFSM4T26TZOQ .