OpenMined / PyDP

The Python Differential Privacy Library. Built on top of: https://github.com/google/differential-privacy
Apache License 2.0
500 stars 138 forks source link

Deprecate support for Python 3.5 and below #338

Closed festusdrakon closed 3 years ago

festusdrakon commented 3 years ago

Closes #334

chinmayshah99 commented 3 years ago

@festusdrakon thanks for the PR, but this PR is essentially dropping support to py35.

What we need to do is add a warning when you use py35 on machines. So in the init.py file, we can check for py35 and raise a deprecation warning. This could go as a new PR.

Changes in the PR needed: Remove py35 from our ci-cd files.

Note: We would be merging this PR when we drop py35 support.

festusdrakon commented 3 years ago

Okay, I'll create a new branch with only the warning and the documentation change and create a new PR from that.

chinmayshah99 commented 3 years ago

Sounds good. Also please keep in mind that this is quite urgent.