OpenMined / PyDP

The Python Differential Privacy Library. Built on top of: https://github.com/google/differential-privacy
Apache License 2.0
506 stars 138 forks source link

added documentation for PyDP naive bayes comparison #359

Closed dnabanita7 closed 3 years ago

dnabanita7 commented 3 years ago

Description

added docs for PyDP comparison

Checklist

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

grilhami commented 3 years ago

@dnabanita7 Great work on adding those descriptions! However, I would like to suggest some minor adjustments.

  1. I think it would be a good idea to mention the description of some variables in a code block like this. For example, instead of just "clf", we can do clf. I think that would help make the description more readable.

  2. For the part where mean_train_accs, mean_test_accs, and dp_results, it'll be great if we can specify that those results are differentially private since the GaussianNB class from PyDP is differentially private.

dnabanita7 commented 3 years ago

cc @chinmayshah99 @grilhami