Wrapper for numerical mechanism class [Continuation from #372]

OpenMined / PyDP

The Python Differential Privacy Library. Built on top of: https://github.com/google/differential-privacy

Apache License 2.0

500 stars 138 forks source link

Wrapper for numerical mechanism class [Continuation from #372] #380

Closed levzlotnik closed 3 years ago

levzlotnik commented 3 years ago

Description

This is continuation of the #372 Pull Request by @dnabanita7. It includes fixes for API and C++ implementation.

[x] Build Process
[x] Dependencies
[x] Python Bindings (C++ side)
[x] Python Bindings (Python side)

Affected Dependencies

[From #372] Added bazel_skylib for com_google_protobuf dependency.

How has this been tested?

Testing WIP. Will test the python side.

Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[x] I have labeled this PR with the relevant Type labels
[x] My changes are covered by tests

levzlotnik commented 3 years ago

@chinmayshah99 Only Windows build is failing, can I continue with the implementation?

chinmayshah99 commented 3 years ago

@chinmayshah99 Only Windows build is failing, can I continue with the implementation?

There are changes in the WORKSPACE file that needs to be removed.

levzlotnik commented 3 years ago

@chinmayshah99 Only Windows build is failing, can I continue with the implementation?

There are changes in the WORKSPACE file that needs to be removed.

What changes?

chinmayshah99 commented 3 years ago

@chinmayshah99 Only Windows build is failing, can I continue with the implementation?

There are changes in the WORKSPACE file that needs to be removed.

What changes?

Last two changes. I don't think those are needed

levzlotnik commented 3 years ago

@chinmayshah99 I've fixed the dependencies, now build works.
I see that there's pydp/ml/mechanisms/ and they are essentially the same as the google-dp numerical mechanisms. Should I replace them with the ones we got from pybind11?

chinmayshah99 commented 3 years ago

I see that there's pydp/ml/mechanisms/ and they are essentially the same as the google-dp numerical mechanisms. Should I replace them with the ones we got from pybind11?

There are some differences in the implementation of the ML part. This can be taken up as a separate PR post the discussion in the slack channel.

chinmayshah99 commented 3 years ago

hi @levzlotnik, the windows py39 build is failing. Can you please take a look into it?

levzlotnik commented 3 years ago

Hey @chinmayshah99, could you please review this? imho it's ready