search

OpenMined / PyDP

The Python Differential Privacy Library. Built on top of: https://github.com/google/differential-privacy
Apache License 2.0
497 stars 136 forks source link

gaussianmechanism function in sklearn_pipeline.py #418

Open SandeepJabez opened 2 years ago

SandeepJabez commented 2 years ago

Description

I have written block of code for the function of gaussian mechanism

grilhami commented 2 years ago

LGTM! Tho I would suggest next time to make the commit bit by bit instead of all of it straight away. It will help to managed changes in codebase. Regardless, I see no issue with the implementation.

@chinmayshah99 Can we merge this soon?

chinmayshah99 commented 2 years ago

seems like there are conflicts. Please look into this.

chinmayshah99 commented 2 years ago

@SandeepJabez there seems to be a bit more conflicts if you can look into it.

SandeepJabez commented 2 years ago

@SandeepJabez there seems to be a bit more conflicts if you can look into it.

yes, i was trying to fix, but ended up making more, I will look into them

SandeepJabez commented 2 years ago

@chinmayshah99 @grilhami I have fixed the conflicts, kindly take a look.