Implement Revocation API

hwrdtm commented 3 years ago

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

Describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
List any relevant details for your test configuration.

Checklist

[ ] I have followed the Contribution Guidelines and Code of Conduct
[ ] I have commented my code following the OpenMined Styleguide
[ ] I have labeled this PR with the relevant Type labels
[ ] My changes are covered by tests

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

hwrdtm commented 3 years ago

We'd talked about writing more notes or helper methods for the proof request and proof presentation steps as they are quite complicated currently, which I fully agree, but think that should be part of a separate PR. @wip-abramson

wip-abramson commented 3 years ago

Yep definitely I think there are a few helper methods to be added. Exactly how these should work is an open question, but something for a separate issue for sure.

wip-abramson commented 3 years ago

Hey @hwrdtm, is this done? Does it need reviewing? Can't remember where we got to

wip-abramson commented 3 years ago

This is complete, awesome job @hwrdtm notebooks look great

OpenMined / PyDentity