search

OpenMined / PyDentity

A repository for leveraging Self-Sovereign Identity in applications
65 stars 25 forks source link

Better Release/Versioning for aries-basic-controller #63

Open wip-abramson opened 3 years ago

wip-abramson commented 3 years ago

Release pipeline

We currently don't really have a process for this. Whenever new features are added to the aries-basic-controller I bump the versioning as needed. We have no process around this and we don't tag releases.

We should explore and develop a much more robust process for releasing new versions.

Who? This is to make it easier for anyone using our library

wip-abramson commented 3 years ago

This seems a good place to start - https://github.com/OpenMined/PyDentity/releases/new.

Not read up on github releases, or how to link to pip https://pypi.org/project/aries-basic-controller/

wip-abramson commented 3 years ago

We should also tidy up our package.

It would be good to export the AriesAgentController directly from aries-basic-controller. See - https://python-packaging-tutorial.readthedocs.io/en/latest/setup_py.html

Currently it is

from aries_basic_controller.agent_controller import AriesAgentController

We want 

from aries_basic_controller import AriesAgentController
wip-abramson commented 3 years ago

It would also be good to add a common dockerfile that installs the basic controller package from pip rather than from the files in the repo.

wip-abramson commented 3 years ago

@morrieinmaas sorry dropping a bunch on messages on your plate.

But after webhooks issue #79 I think we need to target this issue. In that we really ought to push out a new release so may aswell see if we can address this in the process