OpenMined / PyDentity

A repository for leveraging Self-Sovereign Identity in applications
65 stars 25 forks source link

Replace jupyter token authentication with prepared hashed password #67

Open morrieinmaas opened 3 years ago

morrieinmaas commented 3 years ago

Description

Change the default token issuing by jupyter with a password as described in the jupyter docs in order to enable predictable links. This way Alice's notebook can be linked to Bob's properly and reliably and vice verse. This also renders running get_URLS.sh redundant, and hence improves simplicity.

Are you interested in working on this improvement yourself?

Additional Context

Currently, it is necessary to run ./scripts/get_URLS.sh from the root folder to access the notebooks. The URLs are different every time the jupyter server is started. This also makes it impossible to but links from to Bob's notebook in Alice's notebook and vice verse. With a set password this should be possible.

Considerations

Is this compromising any safety aspects? I currently don't think it does since this is meant as a playground to explore. If it does, please, comment on why. And maybe it is then possible to make this optional so that when starting this on local it uses the password and when run on a remote machine it doesn't. However, will the have much benefit then since the links will be broken when running on remote?