search

OpenMined / PyDentity

A repository for leveraging Self-Sovereign Identity in applications
65 stars 25 forks source link

Feature/postgres #80

Closed wip-abramson closed 3 years ago

wip-abramson commented 3 years ago

Description

A postgres db has been added to the multi-tenant agent in the Multitenancy tutorial. This was mostly easy once I had a good place to copy from. I also added a Readme to this tutorial to outline that postrgres was being used. Closes to #71

How has this been tested?

Currently we are just letting docker handle where it stores this db on the local machine. Which I think is fine, although also an option to mount a volume specifically for this.

I think all projects should aim to use postgres from now on. But don't think its necessary to go an update them all. @lohanspies you should use it for your yomo project notebooks.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

morrieinmaas commented 3 years ago

Nice job!

frogman commented 3 years ago

Hi guys. If the sub-wallet tokens are going to be stored inside postgres DB schema, should we try the pgcrypto module to encrypt those columns? Cheers. Z

lohanspies commented 3 years ago

Hey Zeljko,

That is a great idea! Thank you for suggesting that.

On Sun, Apr 4, 2021 at 10:14 PM Zeljko Milinovic @.***> wrote:

Hi guys. If the sub-wallet tokens are going to be stored inside postgres DB schema, should we try the pgcrypto module to encrypt those columns? Cheers. Z

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenMined/PyDentity/pull/80#issuecomment-813093063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFC7SK36AGQAZXIZGV2TDODTHDCARANCNFSM4ZZXVHFQ .

wip-abramson commented 3 years ago

Is this not already done on the agent layer by ACA-Py?

We need to do this up the stack though for sure when YOMA is storing this tokens.

Not sure where we track this. Here is not the best place as it's a dead branch

lohanspies commented 3 years ago

Not sure. Would be great to know if AcaPy handles data encryption at DB level.

frogman commented 3 years ago

Hi. What I have seen, the tokens generated trough AdminAPI are just sent as a JSON output. As we want the AcaPy instances to be stateless , then we need to store those sub-wallet-tokens somewhere. If we choose a postgreDB like AcaPy guys in the OBook setup, then it would be wise to store them in encrypted db columns. There is also a harder way using AWS API gateway to integrate this Lambda. Maybe we start with a simpler approach. We can track this issue in the other forked repo ?