OpenMined / PySyft

Perform data science on data that remains in someone else's server
https://www.openmined.org/
Apache License 2.0
9.43k stars 1.99k forks source link

Remove ALL_READ permission for requests #9095

Closed BrendanSchell closed 1 month ago

BrendanSchell commented 1 month ago

Description

If a DS user calls requests.get_all, it currently retrieves all requests regardless of whether the calling user has read permission on the linked code. This causes issues in the repr when the user is not able to resolve the linked code.

This PR removes ALL_READ from being added to the permissions for requests so that when get_all is called, it'll function similarly to code.get_all where it only retrieves the requests where that user has read permissions (unless they are an admin in which case it will be all requests).

Closes https://github.com/OpenMined/Heartbeat/issues/1561 (and most likely https://github.com/OpenMined/Heartbeat/issues/1637 too).

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

Checklist