OpenMined / SwiftSyft

The official Syft worker for iOS, built in Swift
Apache License 2.0
50 stars 17 forks source link

Fix auth error by tweaking model_version for MNIST example app #189

Closed lukereichold closed 4 years ago

lukereichold commented 4 years ago

Description

Fix auth error by tweaking model_version for MNIST example app to match that of the corresponding model-centric demo Jupyter notebook.

Affected Dependencies

N/A

How has this been tested?

Checklist

codecov[bot] commented 4 years ago

Codecov Report

Merging #189 into dev will decrease coverage by 6.95%. The diff coverage is 16.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #189      +/-   ##
==========================================
- Coverage   52.97%   46.02%   -6.96%     
==========================================
  Files          16       21       +5     
  Lines        1882     2351     +469     
==========================================
+ Hits          997     1082      +85     
- Misses        885     1269     +384     
Impacted Files Coverage Δ
SwiftSyft/Classes/SyftPlan.swift 6.66% <0.00%> (-0.89%) :arrow_down:
SwiftSyft/Classes/TorchWrapper/src/TorchIValue.mm 0.00% <0.00%> (ø)
SwiftSyft/Classes/TorchWrapper/src/TorchModule.mm 0.00% <0.00%> (ø)
SwiftSyft/Classes/TorchWrapper/src/TorchTensor.mm 0.00% <0.00%> (ø)
SwiftSyft/Classes/DataLoader.swift 15.38% <15.38%> (ø)
SwiftSyft/Classes/SwiftSyftError.swift 23.80% <23.80%> (ø)
SwiftSyft/Classes/SignallingMessages.swift 35.03% <50.00%> (ø)
SwiftSyft/Classes/SyftClient.swift 82.93% <70.45%> (+4.21%) :arrow_up:
SwiftSyft/Classes/NetworkManager.swift 75.00% <100.00%> (+1.92%) :arrow_up:
SwiftSyft/Classes/SimplePing.m 80.74% <0.00%> (-1.73%) :arrow_down:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df0e1df...24fab0f. Read the comment docs.

mjjimenez commented 4 years ago

Thank you for this @lukereichold . @all-contributors please add @lukereichold for code

allcontributors[bot] commented 4 years ago

@mjjimenez

I've put up a pull request to add @lukereichold! :tada: