`cat` concatenates `ReplicatedSharedTensor`

OpenMined / SyMPC

A SMPC companion library for Syft

MIT License

99 stars 39 forks source link

`cat` concatenates `ReplicatedSharedTensor` #326

Closed Timo9Madrid7 closed 2 years ago

Timo9Madrid7 commented 2 years ago

Description

refer to issue #324
cat can concatenates ShareTensor, but it is not workable for ReplicatedSharedTensor.
added cat_replicatedShare_tensor in apy.py and static.py for the concatenation of ReplicatedSharedTensor.

Affected Dependencies

How has this been tested?

Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[ ] I have labeled this PR with the relevant Type labels
[ ] My changes are covered by tests

gmuraru commented 2 years ago

Only one comment! I think you also need to run the black formatted and then we are ready to merge this :rocket:

Timo9Madrid7 commented 2 years ago

Only one comment! I think you also need to run the black formatted and then we are ready to merge this 🚀

Ok, I have applied black formatter for api.py and tensor/static.py.

gmuraru commented 2 years ago

Ah..you also need to use the isort. The better solution is to install the pre-commit hooks and they should do the job!

Timo9Madrid7 commented 2 years ago

Ah..you also need to use the isort. The better solution is to install the pre-commit hooks and they should do the job!

Alright! These two files have been checked and passed those tests. Thank you for guiding me.

$ pre-commit run --files src/sympc/api.py src/sympc/tensor/static.py

gmuraru commented 2 years ago

Ah..you also need to use the isort. The better solution is to install the pre-commit hooks and they should do the job!

Alright! These two files have been checked and passed those tests. Thank you for guiding me.
$ pre-commit run --files src/sympc/api.py src/sympc/tensor/static.py

No worries!