Change minimum required CMake version to 3.14 - Githubissues

OpenMined / TenSEAL

A library for doing homomorphic encryption operations on tensors

Apache License 2.0

837 stars 158 forks source link

Change minimum required CMake version to 3.14 #388

Closed vdasu closed 2 years ago

vdasu commented 2 years ago

Description

The minimum required CMake version in the project is 3.13. However, when I build TenSeal from source using CMake 3.13.x I get the following error:

CMake Error at cmake/seal.cmake:12 (FetchContent_MakeAvailable):
      Unknown CMake command "FetchContent_MakeAvailable".
    Call Stack (most recent call first):
      CMakeLists.txt:17 (include)

The FetchContent_MakeAvailable module was introduced in CMake 3.14 (https://cmake.org/cmake/help/v3.14/release/3.14.html#modules). I am able to build and install TenSeal after upgrading CMake to version 3.14.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

Updates have been tested by running the C++ and Python tests.

Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[x] I have labeled this PR with the relevant Type labels
[x] My changes are covered by tests

bcebere commented 2 years ago

Thank you for your contribution!