OpenMined / Threepio

A multi-language library for translating commands between PyTorch, TensorFlow, and TensorFlow.js
Other
56 stars 15 forks source link

Added github action which fails if updates to our compiled json files are needed to be committed #119

Closed ramesht007 closed 3 years ago

ramesht007 commented 4 years ago

Overview

When updates to our crawlers, aggregation script, or new manual translations are added, those updates aren't reflected in threepio.py until we re-run the crawlers & script and then commit the output.

Solution

This PR has a Github Action which will run the crawlers and script and exit with an error if new changes are detected, reminding the user to commit the new compiled output.

Nolski commented 4 years ago

@ramesht007 I suspect this is because the location in which the action is being run is different. It might be worth trying out some debugging tools or looking into the working-directory property that you can use in github actions https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#defaultsrun

ramesht007 commented 4 years ago

ok I will look into it

ramesht007 commented 3 years ago

tried experimenting with something but messed in my local repo and now I will have to refork the repo and then give a new PR. Sorry for any inconvenience.