OpenMined / Threepio

A multi-language library for translating commands between PyTorch, TensorFlow, and TensorFlow.js
Other
56 stars 15 forks source link

Write tests for docs-crawler/docs/docs/spiders/numpy_spider.py #80

Closed tcp closed 4 years ago

tcp commented 4 years ago

Description

docs-crawler/docs/docs/spiders/numpy_spider.py

Type of Test

Expected Behavior

We expect this file to be covered completely by tests. It's not intended to test feature-related functionality but is instead intended to test the file in isolation.

Additional Context

None

ateniolatobi commented 4 years ago

Hello,

I ran through and tested numpy_spider.py and it looks like a rewrite would be needed.

The targeted link for crawling - https://docs.scipy.org/doc/numpy-1.17.0/reference/ has been removed by the Scipy team and the documentation of numpy has also been ported to a standalone site.

I also tried using the new documentation link with the crawler but the page has been restructured so the selectors used in the crawler don't work.

I'll rewrite the file and send a pull request today