Changes to plot. Contributing towards issue - 217 - Githubissues

OpenMined / courses

A place where our community can discuss OpenMined Courses, including posting questions, sharing feedback, or providing comments for discussion!

http://courses.openmined.org

167 stars 74 forks source link

Changes to plot. Contributing towards issue - 217 #429

Open aniket-ak opened 1 year ago

aniket-ak commented 1 year ago

Description

In this PR, there are two changes

The plots created for the published dataset containing 7 countries are such that the X axis contains the countries and Y axis contains the months. It should be other way around. Each line in the plot must represent one country each. This is fixed
The x value in plot_extrapolated_country is hardcoded to 53. I changed this to take the shape of the incoming numpy array to avoid issues when the shape changes

Affected Dependencies

None

How has this been tested?

I have tested the changes on my local machine

Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[x] I have labeled this PR with the relevant Type labels
[x] My changes are covered by tests

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

aniket-ak commented 1 year ago

@shubham3121 FYI.