search

OpenMined / covid-alert

A privacy-preserving app for comparing last-known locations of coronavirus patients
Apache License 2.0
43 stars 14 forks source link

Save keyPair to local storage #16

Closed LaurenSpiegel closed 4 years ago

LaurenSpiegel commented 4 years ago

Addresses https://github.com/OpenMined/covid-alert/issues/8

cereallarceny commented 4 years ago

@LaurenSpiegel I'm going to have @SETIADEEPANSHU now review all PR's for this project. It's in his hands. :)

s0l0ist commented 4 years ago

Unfortunately, this implementation is not complete. We need to instantiate the instance from their class constructors after deserialization.

I've fixed this in my in #17 , however, I do not implement encrypted storage at the moment. Will keep this open until merging.

LaurenSpiegel commented 4 years ago

@s0l0ist , I was avoiding having an async function in a constructor. What is the issue with including in componentDidMount? The keys are available when needed.

cereallarceny commented 4 years ago

Closing in favor of https://github.com/OpenMined/covid-alert/pull/17