OpenMined / sycret

Function Secret Sharing library for Python and Rust with hardware acceleration
https://openmined.github.io/sycret/
Apache License 2.0
54 stars 9 forks source link

[WIP] feat: rust tests #23

Closed danielorihuela closed 3 years ago

danielorihuela commented 3 years ago

Description

Add automatic rust tests as part of the CI/CD and fix current problems. Close #20.

Checklist

tholop commented 3 years ago

@danielorihuela feel free to ping me on Slack (at Pierre Tholoniat) if you have any issues :slightly_smiling_face:

danielorihuela commented 3 years ago

@tholop Hi, yeah, I had some problems making the branches, but I found my way. I wanted to add the mac and windows tests, but I saw that you already started it. Anyway, I saw that there was a bug and I fixed it in https://github.com/OpenMined/sycret/pull/25. Any feedback is appreciated. It worked on a PR that I did to my fork -> https://github.com/danielorihuela/sycret/runs/3205499969

tholop commented 3 years ago

Great, thanks! Please request a review when you're ready and I'll have a look