Attend Clippy warnings - Githubissues

OpenMined / sycret

Function Secret Sharing library for Python and Rust with hardware acceleration

https://openmined.github.io/sycret/

Apache License 2.0

54 stars 9 forks source link

Attend Clippy warnings #35

Closed nph4rd closed 3 years ago

nph4rd commented 3 years ago

Description

There are currently many warnings from clippy if we run something like:

cargo clippy --all-features --all-targets

We should make the pertinent changes to attend them and readjust the GitHub Action workflow to fail on warnings and errors.

Are you interested in working on this improvement yourself?

Yes, I am.

Additional Context

danielorihuela commented 3 years ago

Did you do any research on how to make the CI/CD fail on clippy warnings? Or I can go ahead?

nph4rd commented 3 years ago

We already had that implemented before but was temporarily disabled because we had too many warnings. So it should be no problem to enable it again.

nph4rd commented 3 years ago

For more info, see this commit.

nph4rd commented 3 years ago

We just need to set args: --all-features --all-targets -- -D warnings again.

danielorihuela commented 3 years ago

Aaaaah, okey. I though that it was like a new feature. Then I think is better that you reapply it once the other PR is merged. That way it will be faster.

tholop commented 3 years ago

I just merged PR #36! @arturomf94 feel free to commit the change for the warnings on master directly if you want