Pin maturin version in GitHub Actions

OpenMined / sycret

Function Secret Sharing library for Python and Rust with hardware acceleration

https://openmined.github.io/sycret/

Apache License 2.0

54 stars 9 forks source link

Pin maturin version in GitHub Actions #40

Closed nph4rd closed 3 years ago

nph4rd commented 3 years ago

Description

This will fix the build fail for the release. I think it's better to pin down the version we will use here so that changes in Maturin don't break our pipeline. However I also think it's time to update the Maturin version we're using, so I created a separate issue for that: https://github.com/OpenMined/sycret/issues/39

Affected Dependencies

How has this been tested?

Ran locally

Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[x] I have labeled this PR with the relevant Type labels
[x] My changes are covered by tests

tholop commented 3 years ago

Thanks @arturomf94! Does this PR also fix the current issue with the manylinux flag?

nph4rd commented 3 years ago

It should, momentarily. But I also raised this ticket: https://github.com/PyO3/maturin/issues/636. It has been fixed already so I will open a PR to update the maturin version.

nph4rd commented 3 years ago

I actually think it's better to merge this first, though, because we wouldn't want to rush into a newer version of maturin if we're not sure that it will work for us. Fortunately, maturin was working just fine before, so we should be ok with this fix and we can leave the update for later, whenever there's a release with the patch from https://github.com/PyO3/maturin/issues/636. What do you think?

tholop commented 3 years ago

I agree, thanks @arturomf94 (and nice for reaching out upstream). I'll merge!