search

OpenMobileAlliance / lwm2m-registry

This is a public repository dedicated to store and register new LwM2M Objects
http://www.openmobilealliance.org/wp/OMNA/LwM2M/LwM2MRegistry.html
50 stars 67 forks source link

Adding a new Test Object Definition #623

Closed sbernard31 closed 3 years ago

sbernard31 commented 3 years ago

In Leshan we have kind of Test Object Model which all kind of resource which allow us to do/write some units tests.

Recently a Leshan user opened an issue and I realize that it also create a kind of object like this on its own. (https://github.com/eclipse/leshan/issues/1024#issuecomment-863570941)

Should we register a new Object like this which could help for testing for everybody ?

In case this is not clear those object could have :

sbernard31 commented 3 years ago

@bocajim, @mlasch, @qleisan, @tuve, @rettichschnidi what do you think ?

bocajim commented 3 years ago

Personally (and as the creator of this particular object), I think it would be very helpful if we had a standard test object we encourage all clients/servers to be able to use. As we add more encodings to the spec the number of permutations that need to be tested is difficult to test. Having consistency makes test automation for interoperability much easier, as well as reduces development time validating all of the various encodings.

I've had to have team members implement similar objects in numerous clients and servers to test basic functionality which is a drag on actually developing an application.

And I agree, we need to add an exec so we have all resource types.

I would recommend we move away from my 666 object ID though. :)

jpradocueva commented 3 years ago

With regards to Object Ranges. Please note that in the LwM2M Registry there is a section called "ObjectID Classes", which defines the available Object ranges.

I see two possible options, to use the "reserved" range or the "ext-label" range. The IPSO/DMSE WG should be able to comment on which range is more suitable. @mkgillmore, @hannestschofenig, any comments?

sbernard31 commented 3 years ago

@bocajim would you be OK to register this object at OMA, providing a PR to this repository ? If the process is unchanged since last time, I did that you should first :

@mkgillmore, @hannestschofenig any advice about the ID range which should be chosen?

bocajim commented 3 years ago

Yeah, i can do that, we just got our OMA membership finalized.

Jim

On Thu, Jul 1, 2021, 8:53 AM Simon @.***> wrote:

@bocajim https://github.com/bocajim would you be OK to register this object at OMA, providing a PR to this repository ? If the process is unchanged since last time, I did that you should first :

@mkgillmore https://github.com/mkgillmore, @hannestschofenig https://github.com/hannestschofenig any advice about the ID range which should be chosen?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenMobileAlliance/lwm2m-registry/issues/623#issuecomment-872221107, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJVZ2AHHJP3MZ57Y4FVQR3TVRQNTANCNFSM465VWOEA .

sbernard31 commented 3 years ago

@mkgillmore, @hannestschofenig any comments ?

I guess it just missing the ID range to go forward on this topic ?

seanmcilroy29 commented 3 years ago

@mkgillmore, @hannestschofenig Can you specify which ObjectID class this will be allocated to and I'll begin the registration process?

hannestschofenig commented 3 years ago

Regarding the object id range this object belongs to, I would put it in the 2048 - 10240 range. We could say it comes from the Eclipse Foundation (as a source)

FWIW I think this is a very useful object to register.

seanmcilroy29 commented 3 years ago

ok - I'll reserve the next available ID 3441 under the ext-label, and the Owner will be the Eclipse Foundation

sbernard31 commented 3 years ago

@bocajim, @fdesbiens is it OK to you to make the Eclipse Foundation as the Owner of this Object ? It sounds a good idea to me.

@fdesbiens, just in case you are not aware of this :
LWM2M has a registry where some additional device behavior are defined in Object Model file, Those models can be shared between servers and devices to help for interoperability. See LwM2M Registry for more details.

@seanmcilroy29, @jpradocueva, so the next step is to create an new issue like this : #502 ?

@bocajim could you open the issue :pray: ? (if this is the next step to do)

seanmcilroy29 commented 3 years ago

@bocajim - Here is the readme file that outlines the process - https://github.com/OpenMobileAlliance/lwm2m-registry/blob/prod/README.md

Click here to create a new Issue - this'll provide you with a registration template. Once you submit your Issue, I'll reserve your registration and create a new branch for you to submit your PR.

bocajim commented 3 years ago

@sbernard31 I'm OK with it going under the Eclipse Foundation. Also, someone needs to add an executable resource for completeness.

I'm very busy at the moment, so if you want to wait for me, I'll look at this towards the end of summer, otherwise anyone else is more than welcome to submit it.

fdesbiens commented 3 years ago

@sbernard31 Given the context you provided, it completely makes sense for the Foundation to be the owner. Our open source projects do not have their own juridical personality. Please let me know if you need anything from me to make this happen.

sbernard31 commented 3 years ago

I'm very busy at the moment, so if you want to wait for me, I'll look at this towards the end of summer, otherwise anyone else is more than welcome to submit it.

Thx to let us know that. I have also some task to finished first. I will inform you before to work on this.

sbernard31 commented 3 years ago

@bocajim, I will begin to work on this.

sbernard31 commented 3 years ago

I created the issue to start the process : #636

mkgillmore commented 3 years ago

Closed to do this work due to the creation of #636

jpradocueva commented 3 years ago

@sbernard31 , @mkgillmore I have created a new branch 3442_3443 for you to continue the development of the Test Objects for v1.1 and v1.2.

Please upload one pull request per Object or for both Objects. If you upload multiple pull requests to define an object the tool will identify some missing components and you will have multiple errors. Ping me if you have any questions.

Also, see README.md file to see how to pass validation. Thanks!